prisma-risk / tsoracle / 26317326260

95%

push

github

feat(paxos-toolkit): declare_omnipaxos_types_ext! macro and lifecycle runner (#167)

* feat(paxos-toolkit): declare_omnipaxos_types_ext! macro for downstream type aliases

* feat(paxos-toolkit): LeadershipState newtype mapping to consensus crate

* feat(paxos-toolkit): debounced leader-event channel and stream

* feat(paxos-toolkit): PaxosRunner with tick, outbound drain, leader emission

* refactor(paxos-toolkit): apply code-review feedback on lifecycle layer

Several review-driven cleanups across the lifecycle module:

- LeaderEventSender::send: replace the send_if_modified + is_closed()
  TOCTOU pattern with a borrow-equality check followed by
  watch::Sender::send, which atomically reports closed channels. The
  prior pattern could miss a channel-closed event by one tick and emit
  a spurious extra notify cycle. Updated SendError doc.
- Rewrite the runner's KNOWN LIMITATION comment to drop project
  phase-naming conventions; the comment now describes the limitation
  and points to the follow-up driver crate without referring to plan
  phases.
- PaxosRunner::start: assert in debug builds that the runner isn't
  already running. A double-start was previously silent; now it panics
  in development and at minimum carries an explicit precondition doc.
- PaxosRunner::stop: surface JoinError via tracing::error! rather than
  silently discarding it. A panic in the tick task is unrecoverable
  for paxos and should be visible to the operator.
- Tighten LeadershipState::from_omnipaxos so that current_leader =
  Some(my_node_id) with epoch = None produces Unknown rather than
  "follower of self". The runner always pairs them, but the permissive
  signature should not produce nonsensical output for callers that
  don't. Added a test for the edge case.
- Rename PeerEntry to Peer (the Entry suffix collides in readers'
  mental model with omnipaxos::storage::Entry, which is the log-entry
  trait used throughout the toolkit).
- Add module-level and item-level doc ... (continued)

295 of 368 new or added lines in 4 files covered. (80.16%)

8503 of 8918 relevant lines covered (95.35%)

637133.5 hits per line