prisma-risk / tsoracle / 26315329267

95%

push

github

feat(paxos-toolkit): RocksDB-backed omnipaxos Storage trait implementation (#166)

* feat(paxos-toolkit): RocksdbStorage construction and shared write helpers

* feat(paxos-toolkit): implement Storage log methods over RocksDB

* feat(paxos-toolkit): persist promise and accepted_round to RocksDB

* feat(paxos-toolkit): persist decided_idx, compacted_idx, and trim log prefix

* feat(paxos-toolkit): persist snapshot and stopsign; complete Storage impl

* refactor(paxos-toolkit): apply code-review feedback on storage impl

Six code-quality cleanups:

- Split write_opts into write_sync_opts (sync=true, used for safety-critical
  paths: set_promise / set_accepted_round / append_entry / append_entries /
  append_on_prefix) and write_async_opts (default, used for set_decided_idx
  / set_compacted_idx / trim / set_snapshot / set_stopsign). A node that
  promises ballot N must not forget that promise across a crash, so the
  WAL must be fsync'd before the call returns. Matches the established
  openraft-toolkit pattern.
- Rewrite get_entries to use a single forward iterator instead of N point
  lookups. Aligns with get_suffix's pattern and gives one seek + N
  sequential reads in the hot snapshot-transfer / catch-up paths. Gap
  contract preserved: any missing index in [from, to) still yields an
  empty Vec.
- Remove dead-code `if idx < from { continue }` from get_suffix. The
  iterator's From(start, Forward) seek guarantees every yielded key has
  index >= from, so the guard was unreachable. Add a comment explaining
  the seek invariant.
- Rename `s: Option<StopSign>` to `stopsign` in set_stopsign (project
  convention forbids single-letter parameter names for nouns). Same fix
  for test locals `let b = ballot(...)` → `let expected = ballot(...)`.
- Add struct-level and constructor doc comments to RocksdbStorage and
  open_in, documenting the caller-owns-DB pattern, the CF-must-exist
  precondition, and the ColumnFamilyNotFound error.

521 of 539 new or added lines in 1 file covered. (96.66%)

8208 of 8550 relevant lines covered (96.0%)

666917.86 hits per line