MushroomObserver / mushroom-observer / 26316311962

96%

main: 99%

Pull #4320

github

Inline filter form: shared Phlex component + visual_groups refactor

Two GET-method filter forms in the codebase had similar structure
but drifted Bootstrap-class details:

- field_slips/index — autocompleter filter by project
- visual_groups/edit — text filter for image list

Extract the shared shell into `Components::InlineFilterForm` —
canonical Bootstrap-3 layout owned in one place:

- `.form-inline` on the `<form>` element (per BS3 spec, not on a
  child div)
- `.d-flex.gap-2.align-items-end` row inside so children align to
  the input's baseline regardless of whether the field carries a
  label-on-top stack (autocompleter widgets do; plain inputs may)
- Single source of truth for future inline filter forms

Callers pass `url:`, `submit_text:`, an optional `form_id:`, and a
block that receives the Rails FormBuilder for rendering the field
type appropriate to that page.

Visual-groups filter — combined into one proper form

The status (Included / Excluded / Needs Review) selector was three
separate `<a>` link toggles, separate from the text-filter form.
Rolled both into one `<form>` so:

- Status submit buttons (`name=status value=<s>`) carry the current
  filter text along when clicked
- A hidden `status` field (placed FIRST in DOM) preserves the
  current status when the text-input's submit button is clicked.
  Rails' last-value-wins parsing means a status button's value
  (later in DOM) wins when both are sent.

Reordered "Needs Review" to first position (it's the default).
The active button is rendered as `<span class="btn ... active
disabled" aria-disabled="true">` — non-clickable but visually
selected so users see the current state without a useless click
target. New "Filter text" label distinguishes the input from the
form-wide "Filter Options" heading. Reload button (only on
needs_review) stays as a separate JS-reload link.

`.btn-outline-default.disabled` color fix

BS3's default `.btn.disabled` applies `opacity: 0.65` which greys
out the... (continued)

10 of 10 new or added lines in 1 file covered. (100.0%)

38788 of 40240 relevant lines covered (96.39%)

663.57 hits per line