orneryd / NornicDB / 26290860535
90%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 467
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 85.139% (-0.2%) from 85.37%
26290860535

push

github

orneryd 
 fix(config,nornicdb,docker): honour search-flag precedence end-to-end

  Config values for the four search-index master switches were not flowing
  through the startup path the way the contract claimed. Symptoms (lab
  build 80719f25): operator sets NORNICDB_SEARCH_BM25_ENABLED=false via
  env or --search-bm25-enabled=false via CLI; the container's process
  shows the flag, the Go config layer reads it; default-DB warmup logs
  "Building BM25 + vector indexes for database nornic (bm25=true vector=true)"
  anyway and runs the build.

  Three independent gaps caused this:

  1. cmd/nornicdb/runServe built a fresh nornicdb.DefaultConfig() and
     hand-copied a subset of cfg fields into it. The four Search* fields
     weren't in the copy block, so env+CLI values landed in cfg but never
     reached dbConfig. Replaced the copy block: dbConfig is now an alias
     of cfg, so any field on Config flows automatically. The original
     silent-drop class of bug can't repeat.

  2. nornicdb.Open warms search indexes in a background goroutine that
     raced server.New's SetDbSearchFlagsResolver. When the resolver was
     nil at warmup time, default-DB warmup fell through to global
     defaults instead of per-DB overrides. Added Config.DeferSearchWarmup
     + db.MarkSearchWarmupReady; pkg/server opts in and releases the
     gate AFTER installing the resolver. Embedded callers (scripts,
     tests) keep today's behaviour with no extra wiring.

  3. docker/entrypoint.sh translated env vars to CLI flags but didn't
     forward the four NORNICDB_SEARCH_* vars. Added passthrough lines
     so the flags appear in `ps` / container inspect. Production binary
     path made overridable via NORNICDB_BIN for testability.

  Precedence ladder, lowest → highest, now consistent across every
  configuration source:

    1. Built-in defaults (config.LoadDefaults).
    2. Global config (YAML memory.search_*, NORNICDB_SEARCH_* env).
    3. Per-DB overrides (YAML databases: ... (continued)

21 of 22 new or added lines in 3 files covered. (95.45%)

3656 existing lines in 52 files now uncovered.

129606 of 152229 relevant lines covered (85.14%)

0.99 hits per line

Uncovered Changes

Lines Coverage ∆ File
1
96.3
 0.46% pkg/config/dbconfig/resolver.go

Coverage Regressions

Lines Coverage ∆ File
631
81.35
 -1.03% pkg/search/search.go
326
85.06
 -2.69% pkg/storage/async_engine.go
276
73.65
 0.34% pkg/nornicdb/db.go
232
70.9
 0.16% pkg/cypher/match_index_seek.go
207
87.01
 -1.08% pkg/config/config.go
160
78.42
 0.01% pkg/cypher/merge.go
144
82.27
 -0.14% pkg/cypher/executor_mutations.go
130
82.63
 0.09% pkg/cypher/match_multi.go
128
86.54
 -0.24% pkg/server/server.go
114
83.9
 -3.44% pkg/storage/namespaced.go
104
81.45
 -3.53% pkg/nornicdb/search_services.go
100
78.99
 -6.9% pkg/storage/badger_queries.go
94
54.72
 -39.4% pkg/storage/property_codec.go
87
91.09
 0.0% pkg/cypher/functions_eval_math.go
83
63.21
 -0.94% pkg/cypher/shortest_path.go
77
89.54
 0.0% pkg/cypher/functions_eval_functions.go
70
78.11
 -0.31% pkg/cypher/schema.go
63
84.99
 -1.13% pkg/server/server_nornicdb.go
59
82.35
 0.29% pkg/storage/badger.go
56
69.96
 0.0% pkg/cypher/binding_where_compile.go
55
82.19
 0.0% pkg/cypher/query_patterns.go
50
67.54
 0.0% pkg/cypher/knowledgepolicy_functions.go
48
84.59
 -0.39% pkg/cypher/traversal.go
34
89.61
 -1.57% pkg/cypher/set_helpers.go
32
91.17
 -0.61% pkg/storage/badger_cache.go
26
92.52
 0.0% pkg/cypher/call_apoc_path.go
26
89.07
 0.72% pkg/cypher/executor_mutations_where_eval.go
25
83.13
 -1.52% pkg/storage/wal_engine.go
21
90.3
 -1.9% pkg/cypher/call_vector.go
21
80.29
 0.0% pkg/cypher/match_aggregation.go
20
83.82
 -1.89% pkg/config/dbconfig/store.go
14
86.75
 0.0% pkg/cypher/create.go
14
94.85
 0.0% pkg/storage/types.go
13
76.98
 -2.18% pkg/server/server_qdrantgrpc.go
12
93.22
 0.0% pkg/cypher/case_expression.go
12
93.58
 -6.42% pkg/cypher/parameters.go
12
83.33
 0.13% pkg/nornicdb/storage_recovery.go
10
79.74
 -0.12% pkg/cypher/call.go
9
91.25
 0.0% pkg/cypher/comparison.go
9
84.38
 0.0% pkg/cypher/functions_eval_operators.go
8
95.52
 0.0% pkg/cypher/operators.go
7
86.99
 0.0% pkg/cypher/functions_eval_props_literals.go
6
95.54
 0.0% pkg/cypher/call_apoc_helpers.go
5
95.83
 -4.17% pkg/config/dbconfig/keys.go
5
96.3
 0.46% pkg/config/dbconfig/resolver.go
5
80.28
 0.46% pkg/server/server_dbconfig.go
4
95.21
 0.0% pkg/cypher/functions_helpers.go
3
90.91
 0.0% pkg/cypher/set_merge_strict.go
3
89.47
 0.0% pkg/knowledgepolicy/scorer.go
2
87.05
 -0.3% pkg/cypher/match_rows.go
2
72.31
 -0.65% pkg/fabric/result.go
2
91.48
 -0.66% pkg/temporal/query_load.go
Jobs
ID Job ID Ran Files Coverage
1 26290860535.1 467
85.14
 GitHub Action Run
Source Files on build 26290860535