stillwater-sc / universal / 26289624672
84%
master: 84%

LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Ran
Jobs 1
Files 651
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 84.231% (-0.002%) from 84.233%
26289624672

push

github

web-flow 
fix(elreal): rename _inline member to _inl_buf for MSVC compatibility (#919)

Two related changes:

1. The lazy_component_buffer member `_inline` collides with the MSVC-
   specific `_inline` reserved keyword (a legacy alias for `inline`
   that MSVC still treats specially in some parses). Symptom: MSVC's
   parser sees `_inline{}` in the constructor's member-initializer
   list and interprets it as `inline {}`, cascading into a string of
   C2059 syntax errors. gcc and clang accept the original name.
   Renamed to `_inl_buf` (the inline buffer) -- non-reserved,
   descriptive, mechanical search/replace.

2. UNIVERSAL_BUILD_CI_LITE (the lite CI tier used by the Windows MSVC
   CI runner) did not enable UNIVERSAL_BUILD_NUMBER_ELREALS. As a
   result the K.1 bug above shipped in PR #912 and stayed undetected
   on main. Added ELREALS to CI_LITE so subsequent MSVC-specific
   issues in elreal land at PR-review time, not after merge.

Background
----------

The CI matrix in `.github/workflows/cmake.yml` separates:

- Linux gcc + clang: UNIVERSAL_BUILD_CI=ON (full)
- Windows MSVC, macOS, cross-compilers: UNIVERSAL_BUILD_CI_LITE=ON

The lite tier exists to keep the Windows runner fast (~ 8 min vs
~ 25 min for full). It includes one representative type from each
major category: integer, fixpnt, cfloat, posit, lns, one cascade,
the MX block formats, one elastic (einteger). It did NOT include
the lazy elreal -- the recent multi-PR follow-up epic #903 grew
elreal but the CI matrix wasn't updated to track it.

MinGW cross-compilation, also in the CI matrix, uses gcc as the
compiler (just targeting Windows) and so doesn't surface the MSVC
`_inline` keyword issue. Only the actual MSVC build catches it.

Validation
----------

Local gcc 13.3 and clang 18.1 builds pass after the rename
(behavior unchanged; just a member-name swap). The CI matrix change
adds elreal coverage to the Windows MSVC runner, which would have
caught this bug at the K.1 (#912) PR-review stage... (continued)

46941 of 55729 relevant lines covered (84.23%)

5281919.81 hits per line

Coverage Regressions

Lines Coverage ∆ File
10
31.43
 -3.57% include/sw/universal/verification/test_suite_randoms.hpp
Jobs
ID Job ID Ran Files Coverage
1 26289624672.1 651
84.23
 GitHub Action Run
Source Files on build 26289624672