safe-global / safe-client-gateway / 26284681609

90%

main: 90%

Build Type

Pull #3107

github

Committed by tongyaosafe

Commit Message

fix(surveys): address PR review (uniqueness, slug validation, audit, schema cleanup)

- Make idx_surveys_active a UNIQUE partial index so two rows can't both
  have is_active=true for the same slug. The kill-switch story assumes a
  single active row per slug; this enforces it at the DB.
- Validate the :slug path param with the same Zod schema the DB column
  uses (SurveySlugSchema). Rejects junk input at the controller boundary
  before it reaches the repository.
- Tighten the selections Zod schema with a non-empty .refine, so an
  empty {} now consistently fails ValidationPipe with 422 instead of
  reaching the service-level "missing pages" 400. e2e tests updated.
- Unify SurveyPage.subtitle to .nullable() (was .nullable().optional()),
  matching Survey.subtitle. Same wire shape across the two.
- Expose updatedAt on SpaceSurveyResponseDto and SurveyResponseResultDto,
  and assert in e2e that update_updated_at bumps it on re-submission
  (submittedAt stays pinned to insert time).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #3107: feat: per-Space onboarding survey module

Coverage Stats

4242 of 5108 branches covered (83.05%)

Branch coverage included in aggregate %.

157 of 182 new or added lines in 12 files covered. (86.26%)

2 existing lines in 2 files now uncovered.

16281 of 17784 relevant lines covered (91.55%)

566.62 hits per line