MushroomObserver / mushroom-observer / 26240605024

96%

main: 96%

Build Type

Pull #4315

github

Committed by nimmolo

Commit Message

Cover pre-existing gaps in obs/image controllers to reach 100%

Ratchet per-file coverage on every file touched by this PR. Adds
tests for code paths that were already uncovered on main:

- `images_controller#attach_images_to_projects_and_flash_notices`
  ADD branch (lines 156-157, `project.add_image(img)` + flash). The
  existing test exercised the REMOVE branch only.
  `test_update_image_unchanged_add_to_project` mirrors the remove
  test for the add case.

- `shared_form_methods#save_observation` failure branch (lines
  131-133, flash_error + return false) AND
  `edit_and_update#try_to_update_observation_if_there_are_changes`
  else branch (line 198, `@any_errors = true`). One stub-based test
  in `observations_controller_update_test.rb` covers both:
  `test_update_observation_save_fails`.

- `validators#validate_observation` / `_naming` / `_vote` failure
  branches (`@any_errors = true; false`). Observation, Naming, and
  Vote have no `validates` clauses, so these are only reachable by
  forcing `valid?` to return false. Three stub-based tests via a
  `stub_new_with` helper that intercepts `klass.new` and stubs the
  freshly-built instance.

- `shared_form_methods#try_to_save_image` save-failure branch
  (line 222, `flash_object_errors(image)`). The existing image
  tests trigger the process_image failure path; this one targets
  the save-failure path with a forced `save => false`.

1930 controller tests pass, rubocop clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #4315: Project + species_list membership, `ImagesEditForm` Phlex

Coverage Stats

149 of 149 new or added lines in 11 files covered. (100.0%)

54 existing lines in 3 files now uncovered.

38684 of 40136 relevant lines covered (96.38%)

667.34 hits per line