prisma-risk / tsoracle / 26222535995

95%

push

github

feat(openraft-toolkit): add failpoint sites in RocksdbLogStore::append (#32)

Adds `openraft_toolkit::log_store::before_write_batch` (immediately before
`db.write_opt`) and `openraft_toolkit::log_store::after_write_before_sync`
(between the rocksdb write and `callback.io_completed`) so failpoint tests
can inject crashes inside the window where ordering bugs against openraft's
apply contract are most likely to hide. Closes #24.

The first site uses the single-arg macro form (panic-only). The second uses
the closure form so a `return` action can produce a typed
`Err(io::Error)` — simulating "the durable write succeeded but the
state machine never learned about it".

Adds `crates/openraft-toolkit/tests/failpoints.rs` with one test per site:
panic at `before_write_batch` leaves the log empty after reopen; return at
`after_write_before_sync` leaves the entry persisted after reopen. The
inverse assertions catch a position regression (swapping the two sites'
order flips both tests red), not just an action regression.

Also updates `docs/failpoint-testing.md`: replaces the "feature wired but
no sites yet" notice with a Current Sites row for the crate, and bumps the
opt-in count from two to three crates.

8 of 8 new or added lines in 1 file covered. (100.0%)

2447 of 2616 relevant lines covered (93.54%)

198052.67 hits per line