KarpelesLab / libwallet / 26218873072

22%

push

github

Solana tx-history backfill + DAS payload workaround + bump to 0.4.38

Tibane's two priority asks landed in one release:

  1. Solana tx-history backfill so `Account:setCurrent` /
     `Network:setCurrent` populates `transactions.list(from: …)`
     for Solana wallets, mirroring the EVM behaviour. Uses
     getSignaturesForAddress + getTransaction(jsonParsed) — no
     Helius API key required, works against any standard Solana
     RPC. Each signature condenses into one Transaction row,
     parsed from spl-token / spl-token-2022 / system-program
     transfer instructions (asset = mint for SPL, NATIVE for SOL).
     Anything else (DEX swaps, NFT mints, opaque program calls)
     surfaces as `type: "other"` with the account's net SOL
     balance delta as the amount, so the row still appears in
     the wallet's tx tab.

  2. `getAssetsByOwner` payload fix. The root cause was a
     variadic-packing bug in ethrpc.RPC.DoNamedCtx — it called
     NewRequest(method, args) (variadic, wraps map in slice)
     instead of NewRequestMap(method, args) (sends map directly).
     The wire shape ended up as `"params":[{...}]` instead of
     `"params":{...}`, which Helius reads positionally and
     rejects with `invalid type: map, expected a string at line 1
     column 1`. wltnet.Network.DoRPCNamedCtx now bypasses the
     buggy wrapper and calls `r.SendCtx(ctx,
     ethrpc.NewRequestMap(method, args))` directly. Token
     auto-discovery on Solana works again. The matching upstream
     fix in ethrpc is dispatched to its maintainer; the
     workaround stays regardless.

Plus the two nice-to-haves from the same report:

  - Network.TxHistoryProvider — new computed field exposed via
    MarshalJSON so hosts can distinguish "indexer hasn't
    returned anything yet" (provider non-empty + Transaction
    list empty) from "no indexer implemented on this chain"
    (provider empty). Stable values: "modchain", "otterscan",
    "signatures", or "" (Bitcoin family / cu... (continued)

12 of 272 new or added lines in 3 files covered. (4.41%)

3930 of 17851 relevant lines covered (22.02%)

107.11 hits per line