hyperledger / fabric-x-committer / 26214902617

92%

main: 91%

Build Type

Pull #607

github

Committed by cendhu

Commit Message

Fix timer reset to drain stale ticks before Reset

Use resetBatchTimer helper instead of bare timer.Reset in
batchReceivedTransactionsAndForwardForProcessing. Per Go docs,
Reset must only be called on stopped/expired timers with the
channel drained; otherwise a stale tick may fire immediately.

Place resetBatchTimer after its caller (caller before callee)
and add a reasoning comment. Simplify the test by replacing the
cap(timer.C) check with a brief sleep to let the nanosecond
timer expire, and use t.Cleanup for timer stop.

Signed-off-by: Senthilnathan <cendhu@gmail.com>

Pull Request Pull Request #607: Fix timer reset to drain stale ticks before Reset

Coverage Stats

6 of 7 new or added lines in 1 file covered. (85.71%)

17 existing lines in 6 files now uncovered.

10241 of 11174 relevant lines covered (91.65%)

41067.3 hits per line