iotaledger / iota / 26200321126
67%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1077
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 66.865% (-0.1%) from 67.012%
26200321126

push

github

web-flow 
fix(graphql-rpc): include all dryRunTransactionBlock argument types in query cost evaluation (#11583)

# Description of change

With #9152, we only considered `txBytes` as the eligible argument to
contribute to tx-payload size, but clearly this is not the case if also
`txMeta` is provided in `Query.dryRunTransactionBlock`. It is reminded
that `txBytes` might represent either
[TransactionData](https://iotaledger.github.io/iota/iota_types/transaction/enum.TransactionData.html)
(the richer value) or
[TransactionKind](https://iotaledger.github.io/iota/iota_types/transaction/enum.TransactionKind.html).
If the user passes `txMeta` the latter is assumed. Thus, including
`txMeta` is an eligible candidate for the transaction size.

This patch extends the cost evaluation for arguments pertaining to
transaction execution and fixes this issue.

## Links to any relevant issues

Fixes #11578 

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)

Also ran manual tests with the query reported in the parent issue.

### Infrastructure QA (only required for crates that are maintained by
@iotaledger/infrastructure)

This patch does not affect ingestion or the API.

### Release Notes

- [x] GraphQL: Fixes an issue where passing `txMeta` input in
`Query.dryRunTransactionBlock` could lead to errors due to query limit
checks.

---------

Co-authored-by: Sergiu Popescu <44298302+sergiupopescu199@users.noreply.github.com>
Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>

0 of 19 new or added lines in 2 files covered. (0.0%)

3728 existing lines in 57 files now uncovered.

152092 of 227463 relevant lines covered (66.86%)

462917.77 hits per line

Uncovered Changes

Lines Coverage ∆ File
18
0.0
 0.0% crates/iota-graphql-rpc/src/extensions/query_limits_checker.rs
1
4.74
 -0.03% crates/iota-graphql-rpc/src/server/builder.rs

Coverage Regressions

Lines Coverage ∆ File
587
0.0
 0.0% crates/iota-indexer/src/store/pg_indexer_store.rs
462
81.4
 0.1% crates/iota-core/src/authority.rs
389
12.78
 -1.43% crates/iota-graphql-rpc/src/types/object.rs
242
55.03
 -0.25% crates/iota-replay/src/replay.rs
194
0.0
 0.0% crates/iota-indexer/src/ingestion/primary/prepare.rs
159
29.06
 -4.69% crates/iota-indexer/src/models/objects.rs
151
0.0
 0.0% crates/iota-indexer/src/pruning/pruner.rs
147
80.55
 0.22% iota-execution/latest/iota-adapter/src/execution_engine.rs
114
83.0
 -0.02% crates/iota-types/src/transaction.rs
97
2.03
 0.0% crates/iota-graphql-rpc/src/types/transaction_block_effects.rs
97
60.0
 0.0% crates/iota-json-rpc-types/src/iota_transaction.rs
96
90.35
 -0.83% crates/iota-protocol-config/src/lib.rs
92
4.74
 -0.03% crates/iota-graphql-rpc/src/server/builder.rs
75
89.18
 0.02% crates/iota-network/src/state_sync/mod.rs
69
33.54
 0.21% crates/iota-data-ingestion-core/src/reader/v2.rs
69
0.0
 0.0% crates/iota-graphql-rpc/src/types/balance.rs
61
0.0
 0.0% crates/iota-graphql-rpc/src/types/coin.rs
57
47.66
 0.0% crates/iota-types/src/iota_sdk_types_conversions.rs
55
75.86
 0.48% crates/iota-snapshot/src/reader.rs
55
83.86
 0.02% crates/iota-transactional-test-runner/src/test_adapter.rs
42
0.0
 0.0% crates/iota-graphql-rpc/src/data/pg.rs
41
0.0
 0.0% crates/iota-graphql-rpc/src/types/iota_names_registration.rs
39
70.4
 -0.35% crates/iota-graphql-rpc/src/config.rs
37
83.33
 0.49% iota-execution/latest/iota-move-natives/src/auth_context.rs
35
0.0
 0.0% crates/iota-indexer/src/schema.rs
33
0.0
 0.0% crates/iota-indexer/src/ingestion/primary/persist.rs
31
0.0
 0.0% crates/iota-graphql-rpc/src/types/available_range.rs
31
32.11
 0.0% crates/iota-transactional-test-runner/src/lib.rs
23
0.0
 0.0% crates/iota-graphql-rpc/src/types/dynamic_field.rs
18
68.12
 -4.9% crates/iota-data-ingestion-core/src/reducer.rs
13
73.68
 0.14% crates/iota-data-ingestion-core/src/executor.rs
12
40.21
 0.0% crates/iota-proxy/src/peers.rs
12
93.72
 -0.77% iota-execution/latest/iota-move-natives/src/authentication_context.rs
11
94.76
 -1.98% crates/iota-data-ingestion-core/src/worker_pool.rs
11
92.41
 1.98% crates/iota-types/src/auth_context/mod.rs
6
83.82
 -1.47% crates/iota-core/src/storage.rs
6
0.0
 0.0% crates/iota-data-ingestion-core/src/errors.rs
6
0.0
 0.0% crates/iota-graphql-rpc/src/consistency.rs
6
74.53
 -0.14% crates/iota-network/src/randomness/mod.rs
6
64.62
 0.0% crates/iota-snapshot/src/lib.rs
6
85.59
 -2.7% crates/starfish/core/src/leader_timeout.rs
5
58.33
 0.0% crates/iota-cluster-test/src/cluster.rs
5
99.43
 0.01% iota-execution/latest/iota-move-natives/src/lib.rs
4
89.42
 -0.96% crates/iota-types/src/base_types.rs
2
93.14
 0.0% crates/iota-cluster-test/src/test_case/coin_index_test.rs
2
91.35
 -0.09% crates/iota-core/src/authority/authority_per_epoch_store.rs
2
89.35
 0.0% crates/iota-core/src/connection_monitor.rs
2
90.82
 -0.28% crates/iota-core/src/epoch/randomness.rs
2
0.0
 0.0% crates/iota-graphql-rpc/src/test_infra/cluster.rs
2
91.98
 -0.84% crates/iota-http/src/lib.rs
2
66.67
 -4.17% crates/iota-network-stack/src/anemo_ext.rs
2
91.73
 -0.1% crates/starfish/core/src/header_synchronizer.rs
1
0.0
 0.0% crates/iota-graphql-rpc/src/extensions/query_limits_checker.rs
1
0.0
 0.0% crates/iota-indexer/src/models/system_state.rs
1
89.03
 -0.14% crates/iota-network/src/discovery/mod.rs
1
96.86
 -0.1% crates/starfish/core/src/cordial_knowledge.rs
1
96.48
 -0.03% crates/starfish/core/src/dag_state.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 26200321126.1 1077
66.86
 GitHub Action Run
Source Files on build 26200321126