Alan-Jowett / sonde / 26193029605

82%

Build Type

push

github

Committed by web-flow

Commit Message

node: factory reset at boot when boot button held on paired node (ND-0917) (#1049)

* node: factory reset at boot when boot button held on paired node (ND-0917)

Move factory reset from deferred (inside NODE_PROVISION handler during
BLE pairing) to immediate (at boot, before entering BLE pairing mode).
When the boot button is held >=500 ms on an already-paired node, the
firmware now performs a full factory reset -- erasing PSK, programs, maps,
schedule, channel, BLE pairing artifacts, and staged pre-provisioning
test state -- then enters BLE pairing mode as an unpaired node.

This fixes the radio diagnostic reboot issue: previously, holding the
boot button entered BLE pairing mode with credentials intact and deferred
reset until NODE_PROVISION arrived. If the pairing tool triggered a
radio diagnostic (which reboots the node), the button was no longer held
on the next boot and the node reverted to its paired operational state,
losing the factory-reset intent.

Spec changes:
- ND-0900: boot priority reordered -- button+PSK->reset is now first
- ND-0905: removed button_held/paired_on_entry from NODE_PROVISION
- ND-0917: renamed to "Factory reset via boot button", immediate at boot
- Design updated for new boot flow
- Validation T-N900/T-N906 updated with factory-reset and staged-test steps

Implementation changes:
- KeyStore::factory_reset(): reordered to erase PSK last (partial
  failures leave node paired and retryable); added
  clear_staged_test_command() and clear_test_result()
- handle_node_provision(): removed button_held, paired_on_entry,
  and map_storage parameters -- no longer performs factory reset
- run_ble_pairing_mode(): removed button_held and map_storage
  parameters; added unpaired invariant check (fail-closed)
- node.rs: boot path performs factory reset when button_held && has_psk,
  fail-closed on error (deep sleep)
- Added clear_test_result() to PlatformStorage trait
- New tests for staged-test-clearing and failure-injection paths

Co... (continued)

Coverage Stats

79 of 79 new or added lines in 4 files covered. (100.0%)

6 existing lines in 1 file now uncovered.

36387 of 43696 relevant lines covered (83.27%)

258.6 hits per line