Alan-Jowett / sonde / 26183192770
83%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 128
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.274% (-0.02%) from 83.29%
26183192770

push

github

web-flow 
docs: resolve azure-companion design-vs-implementation drift (#1046)

* docs: resolve azure-companion design-vs-implementation drift

Closes #1031 — addresses 8 of 10 drift items identified in the
azure-companion compliance audit (2 trivial items left as-is).

Design doc changes (azure-companion-design.md):
- A1: Rewrite §4.2 steps 12–20 to clarify that handler deployment,
  Function App activation polling, SPA deployment, and Entra
  configuration all execute inside the bootstrap container — Rust
  monitors stderr markers and updates the modem display
- B1: Add §8.8 documenting custom domain CLI parameters
  (\--custom-domain-name\, \--custom-domain-dns-resource-group\,
  \--custom-domain-dns-zone-name\) passed to the bootstrap container
- B2: Add path traversal protection to §8.4 — lexical rejection of
  \..\, absolute paths, drive prefixes plus canonical containment
- B3: Add cert/key SPKI matching validation to §7.3
- B4: Document RSA/EC(P-256)/EdDSA key acceptance at runtime in §7.3
  (distinct from bootstrap P-256 generation in §8.1)
- B5: Add fallback device-code regex to §8.2 step 7
- B6: Add \service.log\ diagnostic logging to §3.5
- B7: Add graceful shutdown (Stop/Shutdown → StopPending) to §5

Requirements (azure-companion-requirements.md):
- Add AZC-0412: custom domain configuration parameters

Validation (azure-companion-validation.md):
- Add T-AZC-0430: bootstrap passes custom domain params to container
- Add T-AZC-0431: custom domain params accepted via env vars

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* docs: fix custom domain spec to match per-parameter pass-through behavior

Address PR review comments:
- Each custom domain env var is forwarded independently (not gated on
  \--custom-domain-name\)
- Bootstrap script does not currently consume these vars — they are
  passed through for future use
- Existing \SONDE_AZURE_CUSTOM_DOMAIN_ORIGIN\ remains a ... (continued)

36379 of 43686 relevant lines covered (83.27%)

258.67 hits per line

Coverage Regressions

Lines Coverage ∆ File
7
81.12
 -0.28% crates/sonde-azure-companion/src/main.rs
Jobs
ID Job ID Ran Files Coverage
1 26183192770.1 128
83.27
 GitHub Action Run
Source Files on build 26183192770