Alan-Jowett / sonde / 26181875595

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix: resolve gateway design-vs-implementation drift (#1044)

* fix: resolve gateway design-vs-implementation drift (#1024)

Resolve all 10 findings from the gateway design-vs-implementation
compliance audit.

Spec removals (designed but not implemented):
- A1: Remove app bundle deployment from specs (§15 requirements,
  §20 design, §15 validation). Bundle code removal tracked in #1041.
- A2: Remove CLI `install`/`uninstall` subcommand specs (§18.2-18.3).
  MSI and .deb installer paths are retained.
- A3: Remove RSSI signal quality assessment from specs and code.
  `signal_quality` field removed from DIAG_REPLY wire format.
  Pairing tool now computes signal quality locally from raw
  `rssi_dbm` using hard-coded thresholds.
- A4, A5: No action needed (already aligned).

Code removals (implemented but not designed):
- B1/B2: Remove PSK key escrow subsystem (`escrow.rs`, connector
  CBOR keys 12-14, storage trait extensions, engine wiring).
- B3: Remove `Key` admin subcommand (`KeyAction::Fingerprint`).
- B4: Remove `NodeAction::FactoryReset` (keep `Remove` as-is).
- B5: Remove runtime fields (`last_seen`, `last_battery_mv`,
  `battery_history`) from `NodeRecord`. These are already tracked
  in-memory by `SessionManager` per design §7.1a.

Cross-spec consistency: updated protocol.md, protocol-crate-design.md,
protocol-crate-validation.md, and ble-pairing-protocol.md to remove
`signal_quality` references.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* fix: resolve remaining clippy warnings with --all-targets

Remove unused equired_bytes helper in connector.rs (orphaned by
escrow removal), unused with_thresholds parameters and mut in
diag_request tests (orphaned by signal-quality removal), and unused
ecord bindings in e2e tests (orphaned by NodeRecord field removal).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett... (continued)

Coverage Stats

281 of 302 new or added lines in 12 files covered. (93.05%)

3 existing lines in 2 files now uncovered.

36386 of 43707 relevant lines covered (83.25%)

258.55 hits per line