Alan-Jowett / sonde / 26178736020

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix: resolve azure-handler design-vs-implementation drift (#1045)

* fix: resolve azure-handler design-vs-implementation drift (#1029)

Update docs/azure-handler-design.md to document 6 implemented-but-unspecified
features and remove dead PSK escrow code (4 findings).

Specification changes (design doc):

- S1: expand scope and overview to include program ingestion
- S2: add Programs table to managed identity permissions
- S2.1: rewrite trigger model to describe the Azure Functions Custom Handler
  HTTP model (FUNCTIONS_CUSTOMHANDLER_PORT, Axum routes, queue/HTTP trigger
  envelope parsing with specific fallback paths)
- S3.1: broaden "logged and ignored" to cover all non-node `entity_kind`
  values (phone, gateway)
- S4: update intro from "two tables" to "four tables"
- S4.1: add `entity_kind` column to `ActualNodeState` schema, link RowKey to
  new S4.3
- S4.2: update `DesiredNodeState` RowKey reference to S4.3
- S4.3 (new): document three-part history RowKey format
  (`reverse_tick:reverse_sequence:process_nonce`)
- S4.4 (new): document `Programs` table schema (`PartitionKey="program"`,
  `RowKey=hex(program_hash)`)
- S6.1: update SensorData RowKey cross-reference
- S8 (new): full `ProgramIngest` HTTP trigger specification (endpoint, request/
  response schemas, validation rules, error codes, storage behavior), traced to
  WEB-0300 through WEB-0308

Implementation changes (dead code removal):

Remove all PSK key escrow code from `sonde-azure-handler` (~1000 lines):
- `RuntimeConfig::escrow_table` field and env var
- `GatewayStatusDetails`, `KdfParams`, `KeyEscrowPubkeyMessage`,
  `KeyEscrowRequestMessage` structs
- `ConnectorMessage::KeyEscrowPubkey/KeyEscrowRequest/MasterKeyInstall` variants
- 4 `HandlerStore` trait escrow methods and `AzureTablesStore` impls
- Phone-scoped `ACTUAL_STATE` handling (`entity_kind="phone"`)
- Gateway-scoped `status_details` parsing (CBOR keys 10/12/13/14)
- `handle_key_escrow_request`, `encode_key_escrow_response`,
 ... (continued)

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

7 existing lines in 1 file now uncovered.

37288 of 44890 relevant lines covered (83.07%)

252.18 hits per line