release-engineering / Sync2Jira / 26180522490

86%

push

github

Add branch/type filters to transitions and dict-based fixVersion mapping (#460)

* Add branches and issue_types filters to transitions, dict-based fixVersion mapping, and tests

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Fix lint and formatting: remove unused fnmatch import, apply Black

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Address PR #460 review feedback

- Guard noisy log in update_transition when pr_updates is absent
- Simplify base_branch extraction with dict reference instead of .get()
- Split PR filter tests into separate units for _matches_transition_filters
  and update_transition
- Add missing issue test scenarios: absent/empty issue_updates, none-match
  multiple entries, already-matching status, transition=True
- Fix misleading "cumulative" comment in issue test docstring
- Document branches, issue_types filters and dict-based fixVersion mapping

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Harden transition guard and clarify pr_updates docs

- Replace `closed_status is not True` with `isinstance(closed_status, str)`
  to safely skip any non-string value (True, False, None, etc.)
- Show branches/issue_types as keys in the same dict in pr_updates docs
- Add test scenario for transition: False

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Address PR #460 second review: consolidate docs, normalize transition True

- Consolidate merge_transition and issue_updates transition doc entries
  into single entries showing optional filters, per reviewer suggestion
- Fix mapping array description wording
- Normalize legacy transition: True to "Closed" (confirmed by Ralph)
- Update test expectation for True normalization

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Address PR #460 third review: fix doc example and add malformed config warning

Use CUSTOM_TRANSITION placeholder in pr_updates doc example for
consistency, and log a warning when a non-string transition value
is ... (continued)

493 of 611 branches covered (80.69%)

Branch coverage included in aggregate %.

52 of 52 new or added lines in 3 files covered. (100.0%)

1205 of 1376 relevant lines covered (87.57%)

0.88 hits per line