akvo / akvo-mis / #634

88%

main: 88%

push

coveralls-python

Issues with Approval Workflow (#217)

* [#189] fix: Level: Error
local variable 'adm_path' referenced before assignment in GeolocationListView

Sentry issue: https://akvo-foundation.sentry.io/issues/7490644896/?alert_rule_id=15832792&alert_type=issue&notification_uuid=3bc4535c-ace5-4ac3-b0d1-1bef97bf0a27&project=4508924311502848&referrer=issue_alert-slack

* [#216] Hide pending batch from peer approvers when same-Administration colleague has approved

- In list_pending_batch, add a per-batch check inside the existing
  valid_batch_ids loop: if another DataApproval at the user's own
  Administration (scoped to this batch via DataApproval.administration)
  already has status=approved, mark the batch as invalid for the current
  user
- This implements OR semantics (one approval per level is sufficient)
  without mutating DataApproval records — audit trail is preserved
- Add PeerApprovalHiddenTestCase (5 tests) covering: both peers visible
  before any approval, hidden after colleague approves (via API and
  directly), DataApproval record stays PENDING, approved list unchanged

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* [#216] Fix approval status display for multiple approvers at same Administration

- Group approvers by administration before computing status
- Apply OR semantics per group: a level is Approved if any one approver
  has approved (not all), matching the backend completion logic
- Overall status is Approved only if every group has at least one approval
- Remove leftover console.log debug statement

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* [#216] Fix 'Waiting on' column shown in approved tab with wrong peer approver

The filter used key "waiting_on" but the column's actual key is "approver",
making the filter a no-op — the "Waiting on" column always appeared even in
the approved tab, showing same-leve... (continued)

4994 of 5827 branches covered (85.7%)

Branch coverage included in aggregate %.

9632 of 10783 relevant lines covered (89.33%)

0.89 hits per line