Alan-Jowett / sonde / 26141810338
82%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 129
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.918% (+0.02%) from 82.902%
26141810338

push

github

web-flow 
docs: remediate admin CLI trifecta audit findings (#1021)

* docs: remediate admin CLI trifecta audit findings (#1007)

Close all 35 findings from the admin CLI trifecta audit by updating
design and validation specifications.

Design changes:
- Add §6a \\Pairing start — interactive event loop\\ covering the
  \\OpenBlePairing\\ streaming RPC lifecycle, event dispatch table,
  passkey confirmation flow, non-TTY behavior, and loop exit semantics.
  Closes D1 gap for ADMIN-0700.

Validation changes:
- Augment 5 existing tests (T-0100, T-0103, T-0107, T-0108, T-0300)
  with CLI-surface assertions and fix D5 mismatch (CBOR→ELF in T-0300).
- Add 28 new test cases covering CLI process-level behavior for all
  subcommands. Total test cases: 69 (up from 40), CLI process tests: 41
  (up from 9).
- Add structural tests for platform-specific behavior (T-0101b) and
  BLE pairing AC coverage (T-0703a).

The systemic D7 pattern (validation tests exercising the gRPC client
wrapper rather than the CLI binary) is resolved by adding CLI process
tests that invoke \\sonde-admin\\ via \\std::process::Command\\ and
assert on stdout, stderr, and exit codes.

Closes #1007

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* docs: address PR review comments — align specs with implementation

- Fix event variant names to match proto: \\Passkey\\ not \\PasskeyDisplay\\,
  \\PhoneConnected { mtu }\\ not \\{ phone_id }\\, \\PhoneRegistered { label,
  phone_key_hint }\\ not \\{ phone_id }\\
- Fix passkey prompt to \\Confirm pairing? (y/n):\\ per implementation
- Fix proto field name: \\ccept\\ not \\confirmed\\ in \\ConfirmBlePairingRequest\\
- Fix \\--format json\\ claim: global flag is accepted but ignored by
  \\pairing start\\, not rejected by clap
- Fix T-0100: assert \\equired\\ top-level subcommands (CLI also has \\key\\)
- Fix T-0202: use decimal \\key_hint\\ (4660) not hex (0x1234); correct
  PSK ... (continued)

37740 of 45515 relevant lines covered (82.92%)

248.85 hits per line

Jobs
ID Job ID Ran Files Coverage
1 26141810338.1 129
82.92
 GitHub Action Run
Source Files on build 26141810338