KarpelesLab / goro / 26138649539

12%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: re-enable NoDiscard native emit + wrap native methods with attrs

Two changes together:

1. dispatch.go's CallInstanceMethod now wraps native instance methods
   that carry attributes (e.g. NoDiscard on DateTimeImmutable::
   setTimestamp) in a MethodCallable. Previously the bare NativeMethod
   was passed to CallZVal, losing the attribute set — hasNoDiscardAttr
   returned false → lastCallable wasn't set → no warning. The wrapping
   includes Class + AliasName so NoDiscard error messages report the
   correct ClassName::methodName().

2. emit_stmt.go re-enables the native OP_NODISCARD_ENTER/EXIT bracket
   emit (was reverted in 647229d1 due to this exact bug). With (1) in
   place, the native emit now produces the expected warning for both
   user functions and builtin methods.

Fixes attributes/nodiscard/005 (native method) without regressing
attributes/nodiscard/error_code_001 (user function with handler).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

7 of 20 new or added lines in 2 files covered. (35.0%)

43 existing lines in 3 files now uncovered.

14607 of 117677 relevant lines covered (12.41%)

2569.91 hits per line