KarpelesLab / goro / 26138479493

12%

push

github

vm: fix property-assign error message + undefined-var warning

Two regressions from B1 (\$obj->prop = v native emit):

1. objectSet was using receiver.GetType().TypeName() ("bool"/"null")
   for the error message; PHP uses value-specific names ("true"/
   "false"/"null"). Exported compiler.PhpValueTypeName (alias for
   the existing private phpValueTypeName) and switched ops_object.go
   to use it. Fixes bug44660.

2. emitObjectVarAssign loaded the receiver via emitExpr, which for
   a simple variable picked OP_LOAD_LOCAL_OR_WARN. PHP's write
   context for property assignment suppresses the "Undefined
   variable" warning (the AST's runVariable.Run sees
   Parent=runOperator(write)). For simple-variable receivers,
   emit OP_LOAD_LOCAL directly. Fixes bug75921.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

6 of 14 new or added lines in 3 files covered. (42.86%)

14581 of 117666 relevant lines covered (12.39%)

2569.93 hits per line