maximunited / yomu / 26082986255

84%

push

github

fix(ci): fix Node.js installation and deduplicate Coveralls uploads (#44)

* fix(ci): properly initialize nvm for Ubuntu AppVeyor builds

The previous fix used Install-Product which only works on Windows images.
Ubuntu images require sourcing nvm.sh before using nvm commands.

Error from build #223:
"Install-Product: The term 'Install-Product' is not recognized"

Fix:
- Source $NVM_DIR/nvm.sh before nvm commands
- Use sh: multi-line block for proper initialization
- This ensures nvm is available in the shell session

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* fix(ci): ensure nvm activation persists across all AppVeyor steps

Problem:
nvm activation is shell-session scoped. Previous config only activated nvm
in the first install block, so subsequent commands (node -v, npm ci) and
build_script ran in new shells without nvm, using the image's default Node.

This violates the repo's Node >=20.9.0 requirement and causes inconsistent
behavior.

Fix:
- Consolidate all install commands into single sh: | block
- Re-source nvm.sh and nvm use in build_script block
- Ensures all Node/npm commands use the specified version (20)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* fix(ci): use Scrutinizer's pre-installed Node instead of nvm

Problem:
Scrutinizer's base image has outdated GLIBC (< 2.27) that can't run
Node.js 20.x binaries downloaded via nvm, causing build failures:
- GLIBC_2.27 not found
- GLIBC_2.28 not found
- GLIBCXX_3.4.20 not found

Solution:
Enable Scrutinizer's built-in Node installation by uncommenting the
node.version configuration. Scrutinizer's pre-installed Node versions
are compiled for their base image and don't have GLIBC dependencies.

Set to 20.9.0 to match package.json engines requirement (>=20.9.0).

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* fix(ci): prevent duplicate Coveralls uploads on PRs

Problem:
The CI workflow triggers on both 'push' and 'pull_request' events.
When pushing to ... (continued)

682 of 961 branches covered (70.97%)

Branch coverage included in aggregate %.

9993 of 11370 relevant lines covered (87.89%)

34.18 hits per line