MushroomObserver / mushroom-observer / 26082499178

96%

main: 96%

Build Type

Pull #4303

github

Committed by nimmolo

Commit Message

Modal: knobs for header/controller/body_class; refactor Confirm + Spinner

Extends `Components::Modal` with three props so the two remaining
hand-rolled singleton modals (ModalConfirm, ModalProgressSpinner) can
compose Modal instead of inlining their own `.modal > .modal-dialog
> .modal-content` markup. Per the Modal docstring follow-up note,
this finishes the "predate this and inline their own modal markup"
cleanup.

Why central composition: every MO modal goes through one source of
truth for chrome styling. A future BS3 → BS4 / BS5 migration touches
`Components::Modal` once, not N hand-rolled modals.

New Modal props:

- `controller:` (String, default "modal") — Stimulus controller wired
  to the modal root. ModalConfirm uses "confirm-modal" (the Turbo
  confirm-replacement dialog has its own controller that mutates the
  title text and confirm-button action target at runtime).
- `header:` (Boolean, default true) — when false, skip rendering the
  `.modal-header` div entirely. ModalConfirm renders its title inside
  `.modal-body` so the Stimulus controller can target it without
  also tracking a header element; ModalProgressSpinner has no title
  at all. aria-labelledby is still emitted on the root (point it at
  the in-body element via `title_id:`).
- `body_class:` (String, default nil) — extra CSS classes appended
  to `.modal-body`. ModalConfirm wants `py-4`, ModalProgressSpinner
  wants `text-center`.

Refactored components:

- ModalConfirm: composes Modal with `header: false`,
  `controller: "confirm-modal"`, `body_class: "py-4"`,
  `title_id: "mo_confirm_title"`. Renders the title `<h4>` + buttons
  via with_body / with_footer slots.
- ModalProgressSpinner: composes Modal with `header: false`,
  `dialog_class: "modal-dialog modal-sm"`, `body_class: "text-center"`,
  `body_id: "modal_progress_spinner_body"`,
  `title_id: "modal_progress_spinner_caption"`, plus extra_data for
  the non-dismissible settings (keyboard: false, backdrop: static)
  a... (continued)

Pull Request Pull Request #4303: Modal: knobs for header/controller/body_class; refactor Confirm + Spinner

Coverage Stats

25 of 25 new or added lines in 3 files covered. (100.0%)

1 existing line in 1 file now uncovered.

38645 of 40064 relevant lines covered (96.46%)

661.73 hits per line