KarpelesLab / goro / 26082033737

13%

push

github

vm: fix nested isset/empty on string-offset chains

\`isset(\$arr['exists']['non_existent']['sub_sub'])\` where
\$arr['exists'] is a string crashed with a TypeError because the
emit used OP_ARRAY_GET (which throws on string-on-string access)
for intermediate steps.

Adds OP_ARRAY_GET_SAFE + compiler.IssetChainElement helper —
mirrors PHP's permissive isset-read semantics: returns null on
missing key, on null/scalar containers, and on TypeError-shaped
keys (array/object key on a non-object container). The nested-
container emit now uses this opcode; the final OP_ISSET_DIM /
OP_EMPTY_DIM still does the strict exists+not-null check, but
seeing null from a previous OP_ARRAY_GET_SAFE just returns false
without throwing.

Fixes bug60362.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

0 of 117 new or added lines in 3 files covered. (0.0%)

14439 of 117404 relevant lines covered (12.3%)

2555.53 hits per line