node-opcua / node-opcua / 26079274709

92%

push

github

fix: preserve cross-namespace references in toNodeset2XML

When a namespace defines both types (nbTypes>0) and instances
with cross-namespace references (HasInterface, Organizes),
the priority table would sort the user namespace before
companion specs. This caused referenceToKeep() to drop
HasInterface and Organizes references, and the dependency
detection to exclude companion spec namespaces from the
NamespaceUris manifest.

Changes:
- nodeset_to_xml.ts: remove blanket priority filter from
  referenceToKeep(). Priority check now only applies to
  forward Aggregates refs. NonHierarchicalReferences
  (HasInterface) and inverse Organizes are always kept.
- construct_namespace_dependency.ts: bypass priority filter
  for forward NonHierarchicalReferences targets so that
  companion specs are correctly listed as dependencies.
- test_nodeset_to_xml.ts: add NSXML-PRIO-1 test that
  reproduces the bug with a namespace containing both an
  ObjectType and an instance with HasInterface + Organizes
  refs to DI namespace.

18446 of 21745 branches covered (84.83%)

20 of 20 new or added lines in 2 files covered. (100.0%)

164043 of 178213 relevant lines covered (92.05%)

434596.31 hits per line