KarpelesLab / goro / 26065466942

13%

push

github

vm: fix MakeRef-on-cached-ZVal panic in stream user filters

phpv.ZInt(0).ZVal() returns a cached singleton wrapper; calling
MakeRef on it panics. Use NewZVal(ZInt(0)) so the \$consumed by-ref
parameter gets a fresh wrapper. Surface: stream_filter_register +
fwrite drove the panic on bug21478 and bug73156 (which exercise the
same code via __call → eval).

Also drops the unnecessary OffsetSet mirror in OP_NODISCARD_ENTER —
the synthetic __nodiscard_prev_N local only needs the slot, not a
hashtable mirror, and the mirror was contributing to leaked
FuncContext state observed after the panic-recovery path.

Adds OP_DESTRUCTURE_ASSIGN scaffolding (opcode + AssignDestructure
helper); the emit wiring lands in a follow-up.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

0 of 6 new or added lines in 2 files covered. (0.0%)

14424 of 116954 relevant lines covered (12.33%)

2565.33 hits per line