KarpelesLab / goro / 26064566188

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: lower #[NoDiscard]-wrapped statements natively

Brackets the inner statement with OP_NODISCARD_ENTER (calls
compiler.NoDiscardEnter; stores the previous in-context flag as a
bool in a synthetic local) and OP_NODISCARD_EXIT (reads the prev
back, calls compiler.NoDiscardExit which checks LastCallable for
the attribute and emits the warning).

The inner statement is now native-emitted instead of running via
AST delegation, so bodies that only use NoDiscard wraps stay
slot-safe.

Error-path note: if the inner statement throws, OP_NODISCARD_EXIT
is skipped and inNoDiscardContext stays true. This is a rare edge
case (throw inside a NoDiscard call, caught somewhere up the stack)
and only affects EmitNoDiscardForMagicCall's preemptive check —
the AST runner does correctly restore. Acceptable for now; can be
fixed by adding a per-frame defer-action stack in a future change.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

23 of 27 new or added lines in 3 files covered. (85.19%)

165 existing lines in 6 files now uncovered.

14399 of 116806 relevant lines covered (12.33%)

2584.49 hits per line