KarpelesLab / goro / 26060704187

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: lower isset()/empty() for simple-local args natively

Adds OP_ISSET_LOCAL / OP_EMPTY_LOCAL that read the slot directly and
push the boolean result. The emitter picks the native path only when
every argument is a plain `$name` (no array access, no object prop,
no var-var, no class-prop); the complex forms keep the existing AST
delegation.

isValueEmpty is exported as IsValueEmpty so the VM can reuse PHP's
empty-value rules without duplicating them.

Multi-arg isset short-circuits via OP_JMP_IF_FALSE_PEEK, leaving
exactly one bool on the stack regardless of which arg failed.

Bodies that only use isset/empty on simple locals are now slot-safe
— previously any isset() forced the entire body slot-unsafe, paying
a hashtable read on every local access. The complex-arg forms still
trigger slot-unsafe so their AST runner can read operands.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

68 of 88 new or added lines in 5 files covered. (77.27%)

14 existing lines in 1 file now uncovered.

14301 of 116612 relevant lines covered (12.26%)

2599.92 hits per line