KarpelesLab / libwallet / 26057861985

22%

push

github

wltwallet/restretry: transparently retry phplatform 5xx errors

The integration tests (TestRemoteWallet, TestEdDSALocalToRemoteReshare,
TestWalletCreate, and Dart's "RemoteKey new → validate lifecycle")
have been flaking for weeks on phplatform's periodic DB blips —
HTTP 500 with `{"error":"There was a database error while processing
your request, ref: <uuid>"}`. The user has been manually rerunning
CI each time; we even have a memory note documenting the failure
signature.

The blip lasts seconds. Make every libwallet → Crypto/WalletSign:*
call retry transiently:

  - 3 attempts (1 initial + 2 retries)
  - 500ms, 1s exponential backoff
  - retry on HTTP >=500 only (4xx errors are deterministic; retrying
    auth/validation/not-found failures just delays the inevitable)
  - context-cancel-aware (Done ctx aborts the backoff sleep)

Wrapped via restApplyRetry / restDoRetry; the 12 callsites in
remote.go + walletkey.go swap rest.Apply/Do for the wrappers.

Benefit reaches runtime too: a user mid-wallet-creation no longer
sees a confusing error when phplatform has a 2-second DB hiccup —
libwallet retries under the hood.

Tests cover the classifier (5xx → retry, 4xx → pass through, wrapped
errors via errors.As, nil/missing Response defensive) and the loop
contract (first-call success, transient-then-success, permanent
short-circuit, exhausted retries, context cancellation).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

31 of 57 new or added lines in 3 files covered. (54.39%)

3633 of 16547 relevant lines covered (21.96%)

111.99 hits per line