kobotoolbox / kpi / 26039046825

82%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

feat(bulkProcessing): update google transcription and translation flow to accept `bulk_action_uid` DEV-1422 DEV-1499 (#7058)

### 💭 Notes
- `bulk_action_uid` is stored within the `action _data` payload rather
than as top-level version metadata
- `bulk_action_uid` is passed into `process_data()` instead of the NLP
service constructor to minimize changes to existing initialization flows
- Automatic transcription and automatic translation result schemas
inherit support for `bulk_action_uid` through `external_data_schema`, so
no separate result schema modification was required.
- Translation also needs the updated process_data(...,
bulk_action_uid=None) signature because run_external_process() is shared
by all automatic NLP actions.

### 👀 Preview steps
There are no ways to preview this except through unit tests and
validating in the django shell

1. ℹ️ Start the django shell 
2. Create an `AutomaticGoogleTranscriptionAction`
3. Confirm the incoming action payload accepts `bulk_action_uid`:
```
action.validate_data({
    'language': 'en',
    'bulk_action_uid': 'bulk-action-uid',
})
```
4. 🔴 [on main] this should raise a jsonschema.exceptions.ValidationError
5. 🟢 [on PR] this should run without a validation error
6. Confirm the automatic/result payload accepts `bulk_action_uid`:
```
action.validate_external_data({
    'language': 'en',
    'status': 'complete',
    'value': 'Hello world',
    'bulk_action_uid': 'bulk-action-uid',
})
```
7. Confirm the automatic transcription flow passes `bulk_action_uid` to
the NLP service:
```
mock_service = MagicMock()
mock_service.process_data.return_value = {
    'status': 'complete',
    'value': 'Hello world',
}

with patch(
    'kobo.apps.subsequences.actions.automatic_google_transcription.GoogleTranscriptionService',
    return_value=mock_service,
):
    result = action.run_external_process(
        EMPTY_SUBMISSION,
        {},
        {
            'language': 'en',
            'bulk_action_uid': 'bulk-action-ui... (continued)

Coverage Stats

9155 of 12374 branches covered (73.99%)

3 of 5 new or added lines in 4 files covered. (60.0%)

1 existing line in 1 file now uncovered.

30171 of 36922 relevant lines covered (81.72%)

5.74 hits per line