zalando / skipper / 26025786671

80%

Build Type

push

github

Committed by web-flow

Commit Message

proxy: always extract baggage header (#4011)

The OTelBaggage predicate reads baggage via baggage.FromContext, but
skipper never extracted the incoming baggage HTTP header into the
request context. Both the OT bridge and OT tracers discard baggage
extracted from the HTTP header when no valid trace context is present in
the same request.

Fix by always calling propagation.Baggage{}.Extract after span setup in
ServeHTTP, which always populates the context from the baggage header
independently of whether a tracecontext header is present. The W3C
propagator also handles percent-decoding (%3D -> =), so OTelBaggage
matches the logical value regardless of how the upstream encoded it.

---------

Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

6 existing lines in 2 files now uncovered.

27041 of 33814 relevant lines covered (79.97%)

85001.05 hits per line