dangernoodle-io / TaipanMiner / 26011235122

90%

push

github

fix(asic): fall back to chip's effective version mask when pool grants none (TA-380) (#410)

Bench-validated against digi.hmpool.io (vmask=null) and bch.hmpool.io
(vmask=0x1fffe000): bitaxes that previously found 0 shares against
no-mask pools now submit at expected rate; granted-mask pools unchanged.

Root cause: BM1370/BM1368 always rolls version bits within 0x1FFFE000
internally regardless of pool's mining.configure response. When the
pool grants no version mask, the firmware verify path skipped applying
ver_bits, so every chip-rolled nonce failed local SHA256d. Fall back
to the chip's hardcoded mask in both verify and submission paths.

Reuses ASIC_VERSION_MASK from asic_proto.h rather than defining a
new constant.

Latent bug since the original BM1370 driver (#36, jae/ta 274). Surfaced
when digi.hmpool.io stopped acking mining.configure with a
version-rolling grant.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

2373 of 3013 branches covered (78.76%)

Branch coverage included in aggregate %.

4700 of 4871 relevant lines covered (96.49%)

169525.82 hits per line