KarpelesLab / goro / 26002964966

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: lower Cls::IDENT (runClassStaticObjRef) natively

Extracted EvalClassStaticObjRef from runClassStaticObjRef.Run. This
handles the literal-name class const / enum case fetch form — the
most common form in PHP code (\`Cls::CONST\`, \`Cls::EnumCase\`).
Includes the full machinery from the original: trait const blocking,
self/parent/static error-message preservation, visibility checks,
interface/parent walking, attribute deprecation, CompileDelayed
resolution with [constant expression] frame decoration, enum errors,
and typed-const coercion.

Added OP_CLASS_STATIC_OBJREF that pops the class-source value and
pushes the resolved value (const-name from Consts[A]).

This was a complex extraction — 200+ lines of helper logic — but
removes the most common class-const AST delegation from the VM hot
path. The earlier OP_CLASS_DYN_CONST handles the dynamic-name form
(\`Cls::{\$name}\`) via a separate helper.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

28 of 57 new or added lines in 4 files covered. (49.12%)

16 existing lines in 4 files now uncovered.

14232 of 116417 relevant lines covered (12.23%)

2575.86 hits per line