KarpelesLab / goro / 26000405383

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

perf: don't Dup hashtable values inside IterateRaw

IterateRaw was supposed to yield raw values without copying, but its
\`for ; a.Valid(ctx); a.Next(ctx)\` loop drove the cursor through
Next(), which returns Current() — and Current Dups the value. For
array values that triggers ZHashTable.Dup → cow=true on the
underlying hashtable, and the next SetString on it pays for a doCopy.

The cursor-advance return value was always discarded by IterateRaw,
so the Dup was pure waste. Inline the linked-list advance with no
Current() call; skip deleted entries the same way Valid() does.

This also fixes a CI-only regression introduced by eeb6fd41
(concat/bug68118): the per-iteration Dup of \$containers in
FuncContext.Release was still firing because of IterateRaw's Next
call, just less than before. After this commit, bug68118 stops
re-triggering ApplyMaxMemoryLimit's "Failed to set memory_limit"
warning that the CoW churn was indirectly surfacing.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

5 of 8 new or added lines in 1 file covered. (62.5%)

1 existing line in 1 file now uncovered.

14051 of 115913 relevant lines covered (12.12%)

2455.93 hits per line