KarpelesLab / goro / 26000271584

13%

push

github

perf: don't Dup hashtable values during FuncContext.Release (bug60598)

Release iterates the function's locals to call DecRef on objects.
The old loop used ZIterator.Current(), which Dups the value before
returning it. For array values (e.g. \$containers brought in via
\`global \$containers\`), that Dup goes through ZVal.Dup → ZHashTable.Dup,
marking the array CoW. Every subsequent SetString on that array then
triggers doCopy.

bug60598 creates 10000 objects in a loop where each __construct does
\`\$containers[hash] = \$this\` and each __destruct does
\`\$containers[hash] = NULL\`. With the Dup on Release, every one of
those 20000 SetString calls did an O(N) doCopy — runtime was O(N²)
and dominated the 15s timeout (40% in pprof, 11.5s wall time locally).

Switching to NewIterator().IterateRaw(), which calls CurrentRef and
hands back the stored ZVal pointer untouched, drops the wall time
from 11.5s to 0.5s — a 22× speedup. We only inspect the value's type
and DecRef it; no mutation, no sharing.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

2 of 2 new or added lines in 1 file covered. (100.0%)

14051 of 115910 relevant lines covered (12.12%)

2456.53 hits per line