IJHack / QtPass / 25999596093
55%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 72
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 55.418%. Remained the same
25999596093

push

github

web-flow 
test: address five reviewer nits on tst_settings and tst_util (#1502)

Five of seven CodeRabbit findings on tst_settings.cpp and tst_util.cpp
were valid; applying them and skipping two with a rationale.

tst_settings.cpp:

- getPassStore: tighten the "plausible path" predicate. The old
  `startsWith('/') || contains('/')` was redundant and Unix-only;
  switch to `QDir::isAbsolutePath || contains('/') || contains('\\')`
  so Windows paths with backslashes also satisfy the check.
- setAndGetSavestate (profile-keys check): loop over both profile1 and
  profile2 instead of asserting just on profile1. Same git-options
  assertions now cover both entries.

tst_util.cpp:

- CHI_SQUARE_PERMISSIVE_THRESHOLD_DF9: add a comment explaining the
  threshold derivation (above p=0.995 critical value ~23.59 for df=9
  to reduce false failures without losing real bias detection).
- isValidKeyIdInvalid: collapse the 6-line ASSUMED_MAX_KEY_ID_LENGTH /
  TOO_LONG_KEY_ID_LENGTH dance into a single `kTooLongKeyIdLength = 41`
  constexpr with a one-line comment.
- SshAuthSockGuard: move from `namespace {}` to a named
  `namespace testutils`. Qualifies all seven usage sites.

Skipped:

- tst_settings::getPasswordConfigurationDefault: CodeRabbit wanted to
  compare against a default-constructed PasswordConfiguration. Verified:
  this fails when the developer's persistent QSettings hold a non-default
  config (the test class itself warns "Non-portable mode detected: tests
  may modify persistent user settings"). The current `>= 0` check is
  intentionally permissive for non-isolated test runs. Keep it.
- tst_settings isUseGit assertion flip: CodeRabbit's suggested rewrite
  changes the assertions to claim isUseGit auto-detects .git regardless
  of the default arg. Verified against qtpasssettings.cpp:707 — the
  auto-detect branch is guarded by `&& defaultValue`, so it only fires
  when default=true. The current assertions match the production
  behaviour. Suggested rewrite woul... (continued)

3728 of 6727 relevant lines covered (55.42%)

36.69 hits per line

Jobs
ID Job ID Ran Files Coverage
1 25999596093.1 72
55.42
 GitHub Action Run
Source Files on build 25999596093