ruby-grape / grape / 25973130761

97%

master: 97%

Build Type

Pull #2725

github

Committed by ericproulx

Commit Message

Encapsulate Grape::Validations::Validators::Base state behind readers

Route all internal reads of the Base validator's instance variables
through accessor methods instead of touching @ivars directly, in Base
and every subclass.

- Add private `attr_reader :options, :scope, :required, :allow_blank,
  :exception_message`; `:attrs` stays a public reader (unchanged
  external behavior).
- Booleans get `?` aliases consistent with `fail_fast?`:
  `required?`, `allow_blank?`, `fail_fast?` (now `attr_reader` + alias).
- Only `attrs`/`fail_fast?` remain public — the readers actually
  crossing the validator boundary (Grape::Endpoint#run_validators).
- Rename locals that shadowed the new readers (`attrs`/`scope`).

Pure internal refactor: no behavior change, full validation and
endpoint suites green.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #2725: Encapsulate Grape::Validations::Validators::Base state behind readers

Coverage Stats

1084 of 1167 branches covered (92.89%)

Branch coverage included in aggregate %.

53 of 54 new or added lines in 10 files covered. (98.15%)

9 existing lines in 5 files now uncovered.

3497 of 3554 relevant lines covered (98.4%)

32149.28 hits per line