ruby-grape / grape / 25972968115

97%

push

github

Move declaration-coherence checks into ValidationsSpec (#2720)

`check_incompatible_option_values` and `validate_value_coercion` were
private methods on `ParamsScope`, invoked from `#validates` right after
building the `ValidationsSpec`. Both are pure cross-field invariants
computed entirely from fields the spec already owns (`default`,
`values`, `except_values`, `coerce_type`).

`ValidationsSpec` already enforced one construction-time invariant (the
`:type` + `:types` mutual-exclusion `ArgumentError`), so concentrating
the rest there makes "you cannot construct an incoherent spec" true by
definition: the invariant no longer depends on a caller remembering to
run the checks after `.from(...)`. `ParamsScope#validates` shrinks to
build-spec → document → dispatch.

- Moved both methods into `ValidationsSpec` as private; a new private
  `validate!` runs them from `initialize`, before `freeze`.
- Removed both from `ParamsScope` and the two call sites in `#validates`.
- `check_coerce_with` deliberately stays in `ParamsScope#validate_coerce`:
  it is gated on the remountable-API skip (`return unless
  coerce_options[:type]`, because a base instance has no resolved type
  until the mounted instance replays) and is therefore not a pure
  construction-time invariant.

Spec fixture update: `params_documentation_spec` built a spec with
`default: 42, values: [1, 2, 3]` purely to exercise `document_params`;
that combination can no longer be constructed, so the fixture now uses a
coherent `default: 1`.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

1082 of 1167 branches covered (92.72%)

Branch coverage included in aggregate %.

17 of 17 new or added lines in 1 file covered. (100.0%)

3514 of 3573 relevant lines covered (98.35%)

32006.46 hits per line