ruby-grape / grape / 25968435334

97%

push

github

Use an internal Grape::Validations::SharedOptions value object (#2721)

`Validators::Base#initialize` consumed the shared `opts` via
`opts.values_at(:fail_fast, :allow_blank)` and copied the two values
into per-validator ivars.

Introduce `Grape::Validations::SharedOptions`
(`Data.define(:allow_blank, :fail_fast)` with defaults mirroring the
prior `values_at` behaviour) as an *internal* representation: `Base`
builds it from the `opts` Hash —
`SharedOptions.new(**opts.slice(:allow_blank, :fail_fast))` — and
exposes the two fields via `Forwardable.def_delegators :@opts,
:allow_blank, :fail_fast`. `#fail_fast?` calls the delegated
`fail_fast`; `ValuesValidator` (the one subclass reading `@allow_blank`
directly) uses the `allow_blank` reader.

The public 5th-argument contract of `Validators::Base#initialize`
stays a plain Hash, so custom validators and any code that
hand-constructs a validator with a Hash are unaffected. `slice` keeps
the historical tolerance of ignoring unknown keys. `ValidationsSpec`
keeps emitting the `{ allow_blank:, fail_fast: }.freeze` Hash; nothing
about its public surface changes — no UPGRADING entry needed.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@dblock.org>

1085 of 1169 branches covered (92.81%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 3 files covered. (100.0%)

3508 of 3567 relevant lines covered (98.35%)

32042.47 hits per line