orneryd / uiGrid / 25967445418

34%

push

github

fix(grid): expand toggle layout under row selection + react demo scrollbar

  Selection + expand layout
  - isGridPrimaryColumn returned true for visibleColumns[0]. When row
    selection is enabled, the synthetic `selectionRowHeaderCol` is
    prepended at index 0, so the tree/expand toggle and indent calc
    attached to the checkbox cell instead of the first data column. The
    visible artefact: the expand chevron rendered to the LEFT of the row
    selection checkbox.
  - Skip the selectionRowHeaderCol sentinel in isGridPrimaryColumn (TS
    and Rust core, kept identical so WASM-parity specs still hold).
  - Cell shell layout reordered so the expand toggle renders AFTER
    .cell-content with `margin-inline-start: auto`, hugging the trailing
    edge of the primary cell. Tree toggle stays leading because depth
    indentation reads left-to-right.

  React docs page double scrollbar
  - `.react-demo-frame` had `overflow-x: auto`. Per the CSS spec, when
    one axis is non-visible the other is coerced from `visible` to
    `auto`, so the frame grew its own vertical scrollbar in addition to
    the grid's body-viewport scrollbar — reproducible on Linux
    Chrome/Firefox per the bug report.
  - Switched to `overflow: visible` on both axes; horizontal overflow is
    owned by the grid's body viewport internally so the outer frame
    doesn't need its own scroll axis.
  - Aligned `.react-demo-host` height to 620px to match the vanilla
    harness so the three framework demos size identically.

  Regression test
  - cell-state-management.test.ts pins the new layout: with row
    selection and expandable both on, the selection-checkbox cell
    contains no .row-toggle-expand, the first data column does, and
    compareDocumentPosition confirms the toggle sits after
    .cell-content.

1283 of 4460 branches covered (28.77%)

Branch coverage included in aggregate %.

2332 of 6169 relevant lines covered (37.8%)

17.59 hits per line