orneryd / uiGrid / 25966851533

34%

push

github

 Cell selection retention bug
  - Click handlers used closest('.body-cell') which stops at shadow boundaries,
    so clicks on framework-projected light-DOM cell content (Angular ng-template,
    React render props) never resolved to the body cell. The previously focused
    cell kept its cell-focused class, making multiple cells appear "selected"
    simultaneously.
  - Replaced every closest('.body-cell') call in events.ts with a new
    bodyCellFromEvent() helper that walks composedPath(), which crosses the
    shadow boundary correctly.

  Row selection + expandable rows performance regression
  - Each selection toggle ran controller.refresh() which patched every cell in
    every visible row. With expandable rows the primary column also rebuilt the
    expand-toggle markup (icon resolve + label compute + escapeHtml) per cell,
    making the per-row work meaningfully more expensive.
  - patchExistingRows now fingerprints each row's visual state (selection /
    focus / expand / dirty/saving/error / tree level / per-column validity /
    entity reference) and skips patchBodyCell when nothing relevant changed.
  - Selection / focus / expand toggles now only repaint the affected row plus
    the previously- and newly-focused cells, instead of O(rows x cols).
  - Caches are cleared on full re-mount, slow-path innerHTML rebuild,
    setFrameworkRenderedSlots, and template MutationObserver firing.

  Public API
  - Exposed setFrameworkRenderedSlots on VanillaUiGridElement so external
    consumers don't have to cast to call it.
  - Added controller.getEditingCellKey() accessor for the patch path.

  Regression tests
  - New cell-state-management.test.ts covers the cell-focused class transfer,
    composedPath traversal for descendant clicks, slot placeholder rendering,
    framework-projected click via composedPath, selection toggle limited to a
    single row, expand toggle insert/remove, cell-focused survival across an
    unrelated row's selection re... (continued)

1249 of 4442 branches covered (28.12%)

Branch coverage included in aggregate %.

2308 of 6155 relevant lines covered (37.5%)

33.33 hits per line