lsm / neokai / 25951491329

81%

push

github

fix: register node-agent MCP tools in eager-spawn workflow sessions (#1917)

* fix: register node-agent MCP tools in eager-spawn workflow sessions (#1913)

Eager-spawn sessions have IDs ending in `:agent:<name>` rather than
`:exec:<id>`, so `isWorkflowSubSession` was always false for them.
The self-heal block in QueryRunner.start() never fired, leaving
mcp__node-agent__* tools unregistered when the Coding agent ran.

Two fixes:
1. Extend `isWorkflowSubSession` to match `:agent:` session IDs so
   self-heal and structured logging work for eager-spawn sessions.
2. Add `restartQuery({ force: true })` so `reinjectNodeAgentMcpServer`
   can flush the updated server config into the SDK even when the
   eager session's initial empty query has already exited (idle state).

* fix(space): node-agent MCP tools not visible in eager-spawn Coder sessions

Two root causes:

1. `attachSpaceToolsToMemberSession` (space-runtime-service.ts) only skipped
   exec sub-sessions (`:exec:`) but not eager-spawn sessions (`:agent:`). This
   caused a generic `space-agent-tools` server to be hot-swapped onto the
   eager-spawn session via `setMcpServers`, disrupting the node-agent in-process
   MCP server connection and overwriting its specialised context.

2. `QueryOptionsBuilder.build()` set `allowedTools = CODER_TOOLS` (built-in
   tools only) for workflow node-agent sub-sessions without auto-allowing the
   MCP server wildcards. Unlike `space_chat`, which explicitly adds
   `<server>__*` wildcards, Coder sessions had no access to node-agent tools
   even when the server was correctly attached.

* fix(space): force-load workflow MCP tools so agents can see them

Root cause of node-agent tools being unavailable: the Claude Code CLI
defers ALL MCP tools behind tool search by default. Its deferral check
is `isDeferredTool(t) => t.alwaysLoad ? false : t.isMcp ? true : ...` —
every MCP tool is deferred unless explicitly marked alwaysLoad.

A GLM-backed Coder node-agent session's S... (continued)

8351 of 11625 branches covered (71.84%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

67914 of 79803 relevant lines covered (85.1%)

294.02 hits per line