accordproject / concerto / 25937083752

98%

push

github

fix(concerto-core): declare dayjs as a runtime dependency + regression test (#1226)

fix(concerto-core): declare dayjs as a runtime dependency + lint rule

Six files under packages/concerto-core/src/ statically require('dayjs') —
datetimeutil, factory, model/typed, and three under serializer/ — but
the package's package.json never declared dayjs. The package happens
to work when something else in the consuming app's tree hoists dayjs
to a discoverable node_modules; it breaks the moment concerto-core is
the only consumer (surfaced via cicero-template-library 0.26 migration:
accordproject/cicero-template-library#484, where valuegenerator was
the first call site exercised at runtime).

- Add `dayjs` to dependencies (1.11.13, matching sibling packages).
- Wire `eslint-plugin-import`'s `no-extraneous-dependencies` rule via a
  dedicated `.eslintrc.deps.yml` + new `lint:deps` script, chained into
  the existing `lint` (and therefore `pretest`). Scoped to src/ via a
  @typescript-eslint/parser override so the existing JS lint pass is
  untouched. Verified locally: reverting the package.json change makes
  the new script fail with 18 violations across all six call sites.

Signed-off-by: Matt Roberts <code@rbrts.uk>

2055 of 2138 branches covered (96.12%)

Branch coverage included in aggregate %.

3841 of 3871 relevant lines covered (99.23%)

134368.48 hits per line