VolvoxLLC / volvox-bot / 25936780277

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(moderation): standardize patterns and fix divergent code (#928)

* fix(moderation): standardize patterns, add caching, fix guards, remove dead code

* fix(tests): update warnings API tests for caching, pagination, and columns

- Mock cache.js so cacheGetOrSet passes through to factory (prevents
  in-memory cache leaking between tests)
- Update listing test assertion from SELECT * to FROM warnings (now
  uses explicit column list)
- Add count query mock to user summary test (route now runs 4 queries)
- Add pagination fields (total, page, limit, pages) to expected response

* fix: address reviewer feedback on quietMode and warningEngine

- Move keyword detection before try/catch in handleQuietCommand so the
  catch only fires after a keyword match (prevents swallowing unrelated
  messages on error)
- Remove dead .catch() wrappers around processExpiredWarnings calls
  (function has its own try/catch and never rejects)

* fix(cache): add warnings:stats prefix to cacheClear eviction list

Without this, cacheClear() left stale warning stats in Redis until
TTL expiry.

* fix(test): update cache test to expect warnings:stats prefix

The cacheClear test expected 12 prefixes but we added
warnings:stats:* in the previous commit, making it 13.

* fix(api): restore removal_reason, removed_at, updated_at to warning column lists

The explicit column lists introduced in DIV-5 omitted these three
columns. Consumers (including the dashboard) use removal_reason to
distinguish expired from manually removed warnings.

* fix(test): assert cache contract in warnings stats test

Verify cacheGetOrSet is called with the expected key and TTL so the
test fails if the route stops using the cache helper.

* fix(test): add SELECT * regression guard to warnings query test

* ci: re-trigger CI checks

* style: fix import order and test formatting

---------

Co-authored-by: Volvox Bot <bot@volvox.dev>

Coverage Stats

10908 of 12652 branches covered (86.22%)

Branch coverage included in aggregate %.

39 of 41 new or added lines in 8 files covered. (95.12%)

1 existing line in 1 file now uncovered.

16806 of 17839 relevant lines covered (94.21%)

167.18 hits per line