VolvoxLLC / volvox-bot / 25935685440

91%

push

github

fix(moderation): correct bugs in modlog config, OpenAPI enum, action labels, and default reply grammar (#926)

* fix(moderation): correct bugs in modlog config, OpenAPI enum, action labels, and default reply grammar

* fix: use grammatically correct past-tense labels in ACTION_PAST_TENSE

Reviewers flagged that phrases like "had messages purged" produce broken
sentences in both DM ("You have been had messages purged") and reply
("has been had their channel locked") templates. Switch to passive
participles that work after "has been" / "have been":

- untimeout: "removed from timeout"
- purge: "purged"
- lock: "locked"
- unlock: "unlocked"
- slowmode: "put in slowmode"

Also update the hardcoded untimeout.js formatReply to match.

* fix(test): add ACTION_PAST_TENSE to untimeout test mock

modAction.js imports ACTION_PAST_TENSE from moderation.js at module
level. The mock here was missing it — safe today because untimeout.js
always supplies formatReply, but any future test omitting formatReply
would hit a TypeError.

* fix: update ACTION_PAST_TENSE JSDoc and extract pastTense variable

- JSDoc now reflects broader usage (DM notifications + success replies)
  and documents the "has been X" grammar contract.
- Extract nested template literal to a local variable for readability,
  using nullish coalescing instead of logical OR.

* fix(test): add ACTION_PAST_TENSE to moderation mock in all command tests

The modAction.js import of ACTION_PAST_TENSE from moderation.js throws
TypeError when the mock doesn't include it, causing all executeModAction
calls to hit the error path instead of returning success replies.

---------

Co-authored-by: Volvox Bot <bot@volvox.dev>

10887 of 12627 branches covered (86.22%)

Branch coverage included in aggregate %.

16798 of 17831 relevant lines covered (94.21%)

167.26 hits per line