lsm / neokai / 25935094501

81%

push

github

feat: add runtime anti-stuck recovery (#1891)

* feat: add retry threshold to SpaceAgentNotificationService

Suppress `agent_auto_completed` notifications below a configurable
consecutive-failure threshold (default: 3) so normal agent retries
don't flood the space agent. The counter resets on task success,
cancellation, or unsubscribe. Notification messages now include the
consecutive count and estimated total execution time.

* fix: address review feedback on retry threshold implementation

- Clear autoCompletedCounts in subscribe() re-init path to prevent
  stale counters from leaking across re-subscriptions on the same
  instance
- Only delete counter after successful notification delivery so
  transient injectMessage failures don't lose accumulated retry state
- Reset counter on `blocked` task status (not just done/cancelled)
  so manually-restarted blocked tasks start with a fresh cycle
- Add tests for re-subscribe counter cleanup, notification failure
  counter preservation, and blocked task counter reset

* fix: prevent duplicate threshold notifications during pending send

Delete the counter immediately when threshold is reached (preventing
concurrent events from enqueuing duplicates), but restore it on
notification failure so the retry cycle can continue. Added tests for
both the dedup behavior and the failure-restore path.

* fix: remove counter restoration on notification failure

Don't restore autoCompletedCounts on injectMessage failure to avoid
a race where a stale counter is re-inserted after a terminal task
transition (done/cancelled/blocked) has already cleared it. The
counter is unconditionally cleared when threshold is reached,
preventing both duplicate notifications and stale state leaks.

* fix: restore counter on notification failure with terminal-transition guard

Use a notifyInFlight guard set to satisfy both the streak-preservation
and stale-race concerns: counter is restored on injectMessage failure
only when no terminal task... (continued)

8351 of 11625 branches covered (71.84%)

Branch coverage included in aggregate %.

385 of 389 new or added lines in 5 files covered. (98.97%)

67911 of 79800 relevant lines covered (85.1%)

294.02 hits per line