ruby-grape / grape / 25909410425

97%

master: 97%

Pull #2721

github

Introduce Grape::Validations::SharedOptions value object

`ValidationsSpec#shared_opts` was a frozen
`{ allow_blank:, fail_fast: }` Hash, flowing as the 5th `opts` argument
into `Validators::Base#initialize`, whose only use was
`opts.values_at(:fail_fast, :allow_blank)`.

Replace it with a `Grape::Validations::SharedOptions` Data value object
(`Data.define(:allow_blank, :fail_fast)` with defaults mirroring the
prior inline hash — `allow_blank: nil`, `fail_fast: false`).

`Validators::Base` no longer copies the two values into per-validator
ivars: it stores the `@opts` value object and exposes the fields via
`Forwardable.def_delegators :@opts, :allow_blank, :fail_fast`.
`#fail_fast?` now calls the delegated `fail_fast`. `ValuesValidator`
(the one subclass that read `@allow_blank` directly) switches to the
`allow_blank` reader.

Behaviour is unchanged for the normal path — Grape always builds the
`opts` via `ValidationsSpec` and passes it through `ParamsScope#validate`.
The 5th `opts` argument of `Validators::Base#initialize` is now a
`SharedOptions` value object rather than a Hash; custom validators that
forward `opts` to `super` are unaffected, but any code that
hand-constructs a validator with a literal Hash for that argument must
pass `Grape::Validations::SharedOptions.new(...)` instead.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

1084 of 1167 branches covered (92.89%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 3 files covered. (100.0%)

3502 of 3559 relevant lines covered (98.4%)

32108.87 hits per line