IJHack / QtPass / 25836763131

55%

push

github

refactor: drop default arguments from virtual functions (google-default-arguments) (#1488)

Closes the loop on the deferred clang-tidy finding from #1487: defaults
on virtual / override methods are a Google-style anti-pattern because
the default value depends on which static type the call goes through.
Calling `pass_base_ptr->Move(a, b)` would use the base-class default;
calling `pass_derived_ptr->Move(a, b)` would be a compile error if the
override didn't redeclare it. The defaults silently make the value
depend on whether the caller has narrowed the pointer type.

QtPass's Pass interface had this on Move, Copy, Grep, and the
6-arg executeWrapper, with the defaults duplicated on the
ImitatePass/RealPass overrides. Removed from both sides; callers now
pass `false` (or `true,true` for executeWrapper readStdout/readStderr)
explicitly.

Production callsites updated:

- src/storemodel.cpp: 4× Move/Copy in handleDirDrop /
  handleFileToDirDrop — all rely on the force=false default for normal
  drag-drop semantics.
- src/mainwindow.cpp: 2× Move in renameFolder() / renamePassword() —
  same.
- src/pass.cpp: GenerateGPGKeys's executeWrapper call had relied on
  readStdout=true, readStderr=true defaults.

Test callsites updated (3 files):

- tests/auto/util/tst_util.cpp: 2× Grep("anything"/"[invalid").
- tests/auto/integration/tst_integration.cpp: 3× Grep("token"/"url"),
  plus Move/Copy.

Plus .clang-tidy: enable google-default-arguments now that the
codebase is clean.

Build clean, 124/124 tst_util pass, 20/20 tst_integration pass.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

0 of 6 new or added lines in 2 files covered. (0.0%)

3012 of 6726 relevant lines covered (44.78%)

29.88 hits per line