lsm / neokai / 25829666029

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix: clean up agent subprocess groups (#1890)

* fix: clean up agent subprocess groups

Start SDK subprocesses in their own process group, terminate tracked process groups during session stops, and add a watchdog for suspicious long-running child commands.

* fix: scope process watchdog cleanup

Limit watchdog cleanup to daemon-owned process descendants, make elapsed-time parsing portable, and bind deferred force-kills to the terminated process snapshot.

* fix: preserve agent process ownership during cleanup

Keep per-PID force-kill escalation and retain recently exited process groups so watchdog sweeps can still clean up orphaned tool subprocesses.

* chore: trigger CI re-run

* fix: address review feedback on process tracking and cleanup scoping

- Expire recentlyExitedAgentRootPids with 15-minute time-based retention
  to prevent PID-reuse cross-project kills
- Track per-process exit promises and aggregate via Promise.all so
  stop() awaits all tracked roots, not just the latest
- Scope terminateTrackedAgentProcesses to a snapshot taken at stop()
  start so concurrent query starts are not killed by the old stop path
- Update test mocks for new context interface methods

* fix: guard process signals against stale/reused PIDs

- signalTrackedAgentProcesses: gate both group-signal and direct-signal
  on ownership identity (trackedAgentProcesses.get(pid) === proc) so
  stale snapshot entries from PID reuse are skipped
- collectDescendantPids: split root PIDs into live and exited; exited
  roots that appear in the snapshot (reused PIDs) are skipped entirely,
  while truly-exited roots still discover orphaned children via PGID
- Add getTrackedAgentRootPidsSplit() to AgentSession and all managers
  so the watchdog callback passes live/exited roots separately
- Add watchdog tests for reused-PID skipping and orphaned-children
  discovery via exited-root PGID

Coverage Stats

8334 of 11605 branches covered (71.81%)

Branch coverage included in aggregate %.

269 of 358 new or added lines in 8 files covered. (75.14%)

9 existing lines in 3 files now uncovered.

65818 of 78467 relevant lines covered (83.88%)

291.48 hits per line