IJHack / QtPass / 25827655541

55%

Build Type

push

github

Committed by web-flow

Commit Message

cleanup: drop AS_CONST macro + qApp deprecation pragmas (#1472)

Two small mechanical refactors that simplify the source without
changing behaviour.

(a) AS_CONST macro removal
--------------------------

src/helpers.h defined a single macro:

    #if __cplusplus >= 201703L
    #  define AS_CONST(x) std::as_const(x)
    #else
    #  define AS_CONST(x) qAsConst(x)
    #endif

The whole repo now requires C++17 (src/src.pro and tests/tests.pri both
say c++17; CLAUDE.md states "this repository enforces C++17 for all
builds"), so the macro is just an alias for std::as_const. It was used
in two places — switch them to std::as_const directly and delete
helpers.h. Also drop the now-unused #include "helpers.h" from
passworddialog.cpp (it had never used the macro).

(b) qApp deprecation pragmas
----------------------------

Two call sites used the qApp macro inside `#pragma GCC diagnostic
ignored "-Wdeprecated-declarations"` blocks (qApp is deprecated in Qt
6.0+). Replace qApp with QApplication::instance() so the deprecation
warning has nothing to fire on, and remove the surrounding pragma
push/pop blocks (~12 lines) — including the MSVC `#pragma warning`
variants.

No functional change. Tests:
- tst_util: 124/124
- tst_storemodel: 33/33
- tst_filecontent: 21/21
- doxygen: zero warnings from our code

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

1 of 5 new or added lines in 4 files covered. (20.0%)

3 existing lines in 2 files now uncovered.

1956 of 6729 relevant lines covered (29.07%)

26.91 hits per line