KarpelesLab / goro / 25825978521

13%

push

github

vm: flag bodies with class-const access as slot-unsafe

Foo::{\$expr}, \$obj::CONST, Foo::\$bar, and friends are AST-delegated
via OpClassConst. The AST runner reads any operand locals through
the FuncContext hashtable; without slot-unsafety the writes that
preceded the access (e.g. \`\$foo = 'Foo'; … return \$foo::{\$bar};\`
inside eval'd code) went only to the slot cache and the AST saw NULL,
yielding spurious "Undefined variable" warnings.

Should fix constants/dynamic_class_const_fetch and its cache_slot
variant.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

6 of 6 new or added lines in 1 file covered. (100.0%)

14008 of 115845 relevant lines covered (12.09%)

2457.6 hits per line